-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorg: modular file reorganization of C source code - v10 #10029
Conversation
.dirstamp files are a build artifact created when GNU autoconf projects have files spread over multiple directories.
Autoconf used to generate a config.h, but it doesn't anymore, and this ends up ignoring files like util/config.h, which we do not want to happen.
Add clang-format-14 as the preferred version, this is the default on Ubuntu 22.04.
Disable clang-format around byte arrays, as they have likely been manually formatted into something that makes sense for humans. This has been scripted.
ERROR: ERROR: QA failed on build_asan. Pipeline 17008 |
There is some logging code that relies on (parsing) the source code filename, have you looked at how that would work now? |
This logging seems fine:
is there other logging that does filename parsing? |
Hmm, the -DSCFILENAME set by the Makefile is off:
And: https://github.com/OISF/suricata/blob/master/src/util-debug.c#L281 TODO:
|
I think there is some more thought required here... Take 2 examples that adapt well:
But if you apply the same logic to something like
instead of the current module name of
If there is only one |
Logging fixups: #10041 |
Continuation of #9973.
Some tests still fail:
Tasks:
app-layer/
output/eve
output/
util/
util/mpm/
sources/
detect/engine
detect/
The clang-format check will fail. I'm using clang-format-14, the CI check
depends on clang-format-9. See: #9984
Closes #9973.